Reload KnnVectorsFormat in Lucene SPI registry when a Plugin is loaded #129197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
PeteGillinElastic
added
:StorageEngine/Codec
and removed
needs:triage
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
added
:Search Relevance/Vectors
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Contributor
|
This seems more related to vector search. @elastic/search-relevance folks, feel free to send it back to me otherwise. |
Contributor
|
buildkite test this |
ChrisHegarty
changed the title
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
In order for plugins to extend Lucene's KnnVectorsFormat, we need to reload it along with other Lucene SPIs when the plugin classloader is created. This commit adds the call to KnnVectorsFormat.reloadKnnVectorsFormat(loader) in reloadLuceneSPI method, allowing full extension of Lucene's vector functionality through plugins.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
In order for plugins to extend Lucene's KnnVectorsFormat, we need to reload it along with other Lucene SPIs when the plugin classloader is created. This commit adds the call to KnnVectorsFormat.reloadKnnVectorsFormat(loader) in reloadLuceneSPI method, allowing full extension of Lucene's vector functionality through plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for plugins to extend Lucene's KnnVectorsFormat, we need to reload
it along with other Lucene SPIs when the plugin classloader is created.
This commit adds the call to
KnnVectorsFormat.reloadKnnVectorsFormat(loader)in
reloadLuceneSPImethod, allowing full extension of Lucene's vector functionality through plugins.